tag:support.multimarkdown.com,2013-02-12:/discussions/problems-v4/3774-criticmarkup-acceptreject-menu-commands-not-workingMultiMarkdown Software, LLC: Discussion 2020-06-24T17:19:41Ztag:support.multimarkdown.com,2013-02-12:Comment/475648612020-06-24T00:18:59Z2020-06-24T00:18:59ZCriticMarkup accept/reject menu commands not working?<div><p>Charles -- my apologies! I thought I had replied to your message, but did not and found it while cleaning out my inbox.</p>
<p>If this is still not working for you, can you send an example file? The menu commands work with the main text editor (not the criticmarkup assistant). If the cursor is inside a CriticMarkup span, then the menu items will accept/reject the edit (I just tested it and it works.)</p>
<p>Fletcher</p>
<p>PS> You do realize you can't modify CriticMarkup while change tracking is enabled, right?</p></div>Fletchertag:support.multimarkdown.com,2013-02-12:Comment/475648612020-06-24T07:57:53Z2020-06-24T07:57:54ZCriticMarkup accept/reject menu commands not working?<div><p>Hi Fletcher</p>
<p>Great to hear from you, even though I’d forgotten all about this one!</p>
<p>Test file attached, and a little video too. Am I doing it right? I’m not sure whether I had appreciated that tracking has to be off before you try to accept or reject a change, but regardless, it still seems not to work on my screen. I’ve tried it with both “accept” and “reject”, with the cursor positioned inside a change, and – as in the video – selecting the whole change.</p>
<p>The “Accept” and “Reject” buttons in the CM sidebar continue to work fine.</p>
<p>This is Composer 4.5.12 and macOS 10.14.6. on a 2015 MacBook Pro.</p>
<p>Many apologies if I’ve still just misunderstood something.</p>
<p>Very best</p>
<p>Charles</p>
<p>PS While I still think this is a brilliant implementation of CM, I’ve always been dubious about its usefulness in real life and would happily do without it if that meant gave you more time to work on other cool features. I’d be interested to know how much traction you think CM has now.</p>
<p>I’m an editor who tends to make extensive changes to text, so while Composer’s preview of the edited text is excellent, the actual working document quickly becomes very cluttered if change tracking is on. For light editing or commenting, on the other hand, I can see that CM could work well.</p>
<p>Although I hate MS Word, I use it a lot because my customers insist on it. Typically I use change tracking all the time, but with insertions and deletions set not to show. Obviously you can’t do that in Markdown, though I think the ability to show or hide changes in the preview pane would be excellent.</p>
<p>I use the excellent Kaleidoscope quite a bit, for Word files as well as Markdown. I have the feeling that most people who use Markdown are capable of using diff tools too, but maybe I’m wrong about that…</p></div>Charles Butchertag:support.multimarkdown.com,2013-02-12:Comment/475648612020-06-24T12:24:26Z2020-06-24T12:24:26ZCriticMarkup accept/reject menu commands not working?<div><p>Figured it out. Your document contains "non-MMD" "smart" typography<br>
(e.g. the apostrophes). That messed up the character/byte counting in the CriticMarkup parsing. If you replace those with ASCII apostrophes<br>
(which are converted to "smart" apostrophes when exporting via MMD), then it works.</p>
<p>This doesn't happen in the new engine that is used in nvUltra and MMDC<br>
v5, so it will be fixed when those are released.</p>
<p>As for CM more generally, I think it's like Markdown -- it is incredibly<br>
useful for those who know about it and "get it." It's not for everyone,<br>
and that's fine.</p>
<p>And no, it's not very useful for tracking every change throughout the<br>
lifetime of a document. But since Composer can compare two versions of<br>
a document and immediately provide the CM to show the edits between<br>
them, it's very useful when comparing two variations, or for reviewing<br>
changes made by one person on a shared document.</p>
<p>You <em>can</em> set the preview to accept or reject all changes, thereby<br>
hiding them and showing either the "new" or "old" version of a document.</p>
<p>F-</p></div>Fletchertag:support.multimarkdown.com,2013-02-12:Comment/475648612020-06-24T17:19:40Z2020-06-24T17:19:40ZCriticMarkup accept/reject menu commands not working?<div><p>Aha, thank you. I keep smart quotes on because I often use MMDC as a general-purpose writing tool – I just copy chunks of text and use them elsewhere, without exporting. The new behaviour in v5 will be welcome but at least I now know that I should turn off smart quotes if necessary.</p>
<p>And thank you for the tip about “accept all”. Sorry I’d missed that. I’d probably assumed it applied only to exporting. Would be nice to see this in the Format > CriticMarkup menu.</p>
<p>I’ll practice using “Compare to Other File”. This is a very handy feature.</p></div>Charles Butcher