CriticMarkup accept/reject menu commands not working?

Charles Butcher's Avatar

Charles Butcher

27 Aug, 2019 10:07 AM

Is it just me who cannot get the menu commands Format > CriticMarkup > Accept|Reject Selected Change to work?

When I have the CriticMarkup sidebar open, my changes show up and the "Accept" and "Reject" buttons work as expected. But the menu commands seem to have no effect. I've tried (1) in the main editing window, placing the cursor within a CM change, (2) in the main editing window, selecting an entire CM change, and (3) selecting a change via the sidebar. None seems to work.

I'm delighted to see how well Composer handles CM – something I'd previously written off as a nice idea but just too much hassle when you're typing tags manually or relying on, say, a BBEdit plugin. But with syntax colouring and automatic change tracking I think it works brilliantly. For the future I'd appreciate features to toggle between raw text/tracked changes/final version in both the editor and the preview, and it would be great to be able to export change tracking to ODT.

  1. Support Staff 1 Posted by Fletcher on 24 Jun, 2020 12:18 AM

    Fletcher's Avatar

    Charles -- my apologies! I thought I had replied to your message, but did not and found it while cleaning out my inbox.

    If this is still not working for you, can you send an example file? The menu commands work with the main text editor (not the criticmarkup assistant). If the cursor is inside a CriticMarkup span, then the menu items will accept/reject the edit (I just tested it and it works.)

    Fletcher

    PS> You do realize you can't modify CriticMarkup while change tracking is enabled, right?

  2. 2 Posted by Charles Butcher on 24 Jun, 2020 07:57 AM

    Charles Butcher's Avatar

    Hi Fletcher

    Great to hear from you, even though I’d forgotten all about this one!

    Test file attached, and a little video too. Am I doing it right? I’m not sure whether I had appreciated that tracking has to be off before you try to accept or reject a change, but regardless, it still seems not to work on my screen. I’ve tried it with both “accept” and “reject”, with the cursor positioned inside a change, and – as in the video – selecting the whole change.

    The “Accept” and “Reject” buttons in the CM sidebar continue to work fine.

    This is Composer 4.5.12 and macOS 10.14.6. on a 2015 MacBook Pro.

    Many apologies if I’ve still just misunderstood something.

    Very best

    Charles

    PS While I still think this is a brilliant implementation of CM, I’ve always been dubious about its usefulness in real life and would happily do without it if that meant gave you more time to work on other cool features. I’d be interested to know how much traction you think CM has now.

    I’m an editor who tends to make extensive changes to text, so while Composer’s preview of the edited text is excellent, the actual working document quickly becomes very cluttered if change tracking is on. For light editing or commenting, on the other hand, I can see that CM could work well.

    Although I hate MS Word, I use it a lot because my customers insist on it. Typically I use change tracking all the time, but with insertions and deletions set not to show. Obviously you can’t do that in Markdown, though I think the ability to show or hide changes in the preview pane would be excellent.

    I use the excellent Kaleidoscope quite a bit, for Word files as well as Markdown. I have the feeling that most people who use Markdown are capable of using diff tools too, but maybe I’m wrong about that…

  3. Support Staff 3 Posted by Fletcher on 24 Jun, 2020 12:24 PM

    Fletcher's Avatar

    Figured it out. Your document contains "non-MMD" "smart" typography
    (e.g. the apostrophes). That messed up the character/byte counting in
    the CriticMarkup parsing. If you replace those with ASCII apostrophes
    (which are converted to "smart" apostrophes when exporting via MMD),
    then it works.

    This doesn't happen in the new engine that is used in nvUltra and MMDC
    v5, so it will be fixed when those are released.

    As for CM more generally, I think it's like Markdown -- it is incredibly
    useful for those who know about it and "get it." It's not for everyone,
    and that's fine.

    And no, it's not very useful for tracking every change throughout the
    lifetime of a document. But since Composer can compare two versions of
    a document and immediately provide the CM to show the edits between
    them, it's very useful when comparing two variations, or for reviewing
    changes made by one person on a shared document.

    You *can* set the preview to accept or reject all changes, thereby
    hiding them and showing either the "new" or "old" version of a document.

    F-

  4. 4 Posted by Charles Butcher on 24 Jun, 2020 05:19 PM

    Charles Butcher's Avatar

    Aha, thank you. I keep smart quotes on because I often use MMDC as a general-purpose writing tool – I just copy chunks of text and use them elsewhere, without exporting. The new behaviour in v5 will be welcome but at least I now know that I should turn off smart quotes if necessary.

    And thank you for the tip about “accept all”. Sorry I’d missed that. I’d probably assumed it applied only to exporting. Would be nice to see this in the Format > CriticMarkup menu.

    I’ll practice using “Compare to Other File”. This is a very handy feature.

Reply to this discussion

Internal reply

Formatting help / Preview (switch to plain text) No formatting (switch to Markdown)

Attaching KB article:

»

Attached Files

You can attach files up to 10MB

If you don't have an account yet, we need to confirm you're human and not a machine trying to post spam.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac